All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Michele Curti <michele.curti@gmail.com>
Cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/vdso: use NULL instead of zero
Date: Tue, 16 Sep 2014 10:36:18 +0200	[thread overview]
Message-ID: <20140916083618.GA1712@gmail.com> (raw)
In-Reply-To: <20140916083109.GA802@powerline.azcom-win.it>


* Michele Curti <michele.curti@gmail.com> wrote:

> 
> x86/vdso: use NULL instead of zero in patch_vdso32()
> 
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
> 
> diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
> index 1ad1026..a4647bc 100644
> --- a/arch/x86/vdso/vma.c
> +++ b/arch/x86/vdso/vma.c
> @@ -34,7 +34,7 @@ static unsigned vdsox32_size;
>  void __init patch_vdso32(void *vdso, size_t len)
>  {
>  	Elf32_Ehdr *hdr = vdso;
> -	Elf32_Shdr *sechdrs, *alt_sec = 0;
> +	Elf32_Shdr *sechdrs, *alt_sec = NULL;
>  	char *secstrings;
>  	void *alt_data;
>  	int i;

Your patch does not apply, this code got significantly reworked 
in the following commit, earlier this year:

  6f121e548f83 x86, vdso: Reimplement vdso.so preparation in build-time C

Thanks,

	Ingo

      reply	other threads:[~2014-09-16  8:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140915143939.GA1953@powerline.azcom-win.it>
     [not found] ` <20140916065732.GA19849@gmail.com>
2014-09-16  8:31   ` [PATCH] x86/vdso: use NULL instead of zero Michele Curti
2014-09-16  8:36     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140916083618.GA1712@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michele.curti@gmail.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.