From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: net: fec: change data structure to support multiqueue
Date: Tue, 16 Sep 2014 09:39:35 +0000 [thread overview]
Message-ID: <20140916093935.GA24540@mwanda> (raw)
Hello Fugang Duan,
The patch 4d494cdc92b3: "net: fec: change data structure to support
multiqueue" from Sep 13, 2014, leads to the following static checker
warning:
drivers/net/ethernet/freescale/fec_main.c:1418 fec_enet_rx_queue()
warn: add curly braces? (if)
drivers/net/ethernet/freescale/fec_main.c
1413
1414 /* Extract the frame data without the VLAN header. */
1415 skb_copy_to_linear_data(skb, data, (2 * ETH_ALEN));
1416 if (vlan_packet_rcvd)
1417 payload_offset = (2 * ETH_ALEN) + VLAN_HLEN;
1418 skb_copy_to_linear_data_offset(skb, (2 * ETH_ALEN),
1419 data + payload_offset,
1420 pkt_len - 4 - (2 * ETH_ALEN));
The patch pushed this call to skb_copy_to_linear_data_offset() in one
indent level but didn't add curly braces. It's not clear to me if the
indenting was intentional or not.
1421
1422 skb->protocol = eth_type_trans(skb, ndev);
1423
regards,
dan carpenter
next reply other threads:[~2014-09-16 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 9:39 Dan Carpenter [this message]
2014-09-16 10:16 ` net: fec: change data structure to support multiqueue fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916093935.GA24540@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.