Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

[Luiz Capitulino <lcapitulino@redhat.com>]

On Tue, 16 Sep 2014 15:43:14 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Tue, 16 Sep 2014 09:25:02 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Luiz Capitulino <lcapitulino@redhat.com> writes:
> >> 
> >> > When a QMP client changes the polling interval time by setting
> >> > the guest-stats-polling-interval property, the interval value
> >> > is stored and manipuled as an int64_t variable.
> >> >
> >> > However, the balloon_stats_change_timer() function, which is
> >> > used to set the actual timer with the interval value, takes
> >> > an int instead, causing an overflow for big interval values.
> >> >
> >> > Fix it.
> >> >
> >> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >> 
> >> Subject claims buffer overflow, but description suggests integer
> >> overflow.  Which one is it?
> >
> > Integer.
> 
> Thanks.  If you fix the subject, you can add my R-by.

I've fixed the subject, but I've also added a new hunk to the patch.