From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 07/11] drm/i915: Clarify irq_lock locking, irq handlers
Date: Tue, 16 Sep 2014 12:28:18 +0200 [thread overview]
Message-ID: <20140916102818.GD31703@phenom.ffwll.local> (raw)
In-Reply-To: <20140916102152.GB11667@nuc-i3427.alporthouse.com>
On Tue, Sep 16, 2014 at 11:21:52AM +0100, Chris Wilson wrote:
> On Mon, Sep 15, 2014 at 02:35:07PM +0200, Daniel Vetter wrote:
> > irq handlers always run with interrupts locally disabled, so
> > plain spinlocks is all we need. I've also reviewed again that they
> > all follow the _irq_handler postfix convention.
>
> Hmm, we still have the full irq dance inside the reg read/write macros,
> which themselves should never be used from inside the irq handlers.
>
> (Modulo the misgivings in execlists_irq_handler).
Hm, we still have the ACTHEAD hack to read somewhat coherent-ish seqnos.
Dunno whether open-coding that would make sense really, and whether it's
really beneficial to force register writes to never acquire forcewake from
irq context. Definitely material for different patches though.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-16 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 12:35 [PATCH 00/11] Spinlock use clarification in i915 Daniel Vetter
2014-09-15 12:35 ` [PATCH 01/11] drm/i915: Clarify event_lock locking, process context Daniel Vetter
2014-09-15 12:35 ` [PATCH 02/11] drm/i915: Clarify event_lock locking, irq&mixed context Daniel Vetter
2014-09-15 12:35 ` [PATCH 03/11] drm/i915: Clarify gpu_error.lock locking Daniel Vetter
2014-09-15 12:35 ` [PATCH 04/11] drm/i915: Clarify irq_lock locking, intel_tv_detect Daniel Vetter
2014-09-15 12:35 ` [PATCH 05/11] drm/i915: Clarify irq_lock locking, work functions Daniel Vetter
2014-09-15 12:35 ` [PATCH 06/11] drm/i915: Clarify irq_lock locking, interrupt install/uninstall Daniel Vetter
2014-09-15 12:35 ` [PATCH 07/11] drm/i915: Clarify irq_lock locking, irq handlers Daniel Vetter
2014-09-16 10:21 ` Chris Wilson
2014-09-16 10:28 ` Daniel Vetter [this message]
2014-09-16 10:53 ` Chris Wilson
2014-09-15 12:35 ` [PATCH 08/11] drm/i915: Clarify irq_lock locking, special cases Daniel Vetter
2014-09-15 12:35 ` [PATCH 09/11] drm/i915: Convert backlight_lock to a mutex Daniel Vetter
2014-09-16 6:43 ` Jani Nikula
2014-09-16 7:56 ` Daniel Vetter
2014-09-15 12:35 ` [PATCH 10/11] drm/i915: Clarify uncore.lock locking Daniel Vetter
2014-09-15 12:35 ` [PATCH 11/11] drm/i915: Clarify mmio_flip_lock locking Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2014-09-15 12:55 [PATCH 00/11] Spinlock use clarification in i915 Daniel Vetter
2014-09-15 12:55 ` [PATCH 07/11] drm/i915: Clarify irq_lock locking, irq handlers Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916102818.GD31703@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.