From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 38/89] drm/i915/skl: Implement drm_plane vfuncs Date: Tue, 16 Sep 2014 14:20:01 +0100 Message-ID: <20140916132001.GF26627@strange.amr.corp.intel.com> References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com> <1409830075-11139-39-git-send-email-damien.lespiau@intel.com> <20140904132116.GQ15520@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FF6F6E42A for ; Tue, 16 Sep 2014 06:20:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140904132116.GQ15520@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 04, 2014 at 03:21:16PM +0200, Daniel Vetter wrote: > On Thu, Sep 04, 2014 at 12:27:04PM +0100, Damien Lespiau wrote: > > SKL Uses the same hardware for all planes now, so called "universal" > > planes. Ie both the primary planes and sprite planes share the same > > logic. This patch implements the drm_plane vfuncs for "sprites" ie > > planes that aren't the primary plane. > > > > v2: Couple of fixes: > > - Actually enabled the planes and fix the plane number > > > > Signed-off-by: Damien Lespiau > > This needs to be de-duped I think ... I was hoping to do that in a separate task on top. Right now the two code paths are not quite ready to be merged together, close though. > especially since it will conflict quite badly with Padovan's ongoing > work to introduce a struct intel_plane_config. > > Not sure yet how we can shuffle the merge here, I guess it'll be a > case of who's first wins ;-) mine mine mine :) well, we shall see, so far, so good. -- Damien