From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1XTw8w-0002tH-KN
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 13:02:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1XTw8q-00021K-GU
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 13:02:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50781)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1XTw8p-00020q-WA
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 13:02:12 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8GG54GN013619
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 16 Sep 2014 12:05:05 -0400
Date: Tue, 16 Sep 2014 13:03:57 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20140916160357.GA30753@amt.cnet>
References: <20140916151437.GA27819@amt.cnet>
 <54185A58.2010105@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54185A58.2010105@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of
	cpu_clean_all_dirty
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote:
> Il 16/09/2014 17:14, Marcelo Tosatti ha scritto:
> > +	/*
> > +	 * Make sure that CPU state is synchronized from KVM
> > + 	 * once every VM state change callback has finished.
> 
> Which other callback could affect the in-kernel state, 

Do you want me to find out exactly which callback is changing 
the in-kernel interrupt state?
To be honest: i don't know.

> and should that call cpu_clean_all_dirty instead?

Does not make sense: any callback which modifies any in-kernel register
state should clean dirty state because its possibly set.