From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33294)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XTvnY-0001kt-MA
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:40:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XTvnR-00040R-9o
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:40:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60676)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XTvnR-0003qP-3B
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:40:05 -0400
Date: Tue, 16 Sep 2014 19:43:21 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140916164321.GB8628@redhat.com>
References: <1410882204-9836-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-dTcPATxbi2TUtvMg4d+rNsYJ9KDSPYvJK1M9=kr-brA@mail.gmail.com>
	<54186401.9040705@redhat.com>
	<CAFEAcA8pusT_BWe8zqJGET76V2dXvo7VQuu6M97sxPorpaXAog@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8pusT_BWe8zqJGET76V2dXvo7VQuu6M97sxPorpaXAog@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib
 between 2.16 and 2.38
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Eduardo Habkost <ehabkost@redhat.com>

On Tue, Sep 16, 2014 at 09:28:03AM -0700, Peter Maydell wrote:
> On 16 September 2014 09:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 16/09/2014 18:20, Peter Maydell ha scritto:
> >>> > - bumping the minimum required version from 2.12 to 2.16.  I suggest
> >>> > bumping to the currently required version for Windows, which is 2.20
> >>> > (released March 2009).
> >> The commit message for a52d28afb suggests that this bump would be
> >> dropping support for RHEL5. That doesn't seem like a great idea
> >> to me, especially if it's only for the benefit of a test program.
> >
> > Though you would just drop support for "make check" on RHEL5.  Even
> > "make -k check" would roughly work.
> 
> Can't we just put in the makefile and configure magic to skip
> the test if the glib version is too old for it?
> 
> -- PMM

That's exactly what my patch did.
See 20140916144324.GA7804@redhat.com

You prefer that then?