From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 11/12] IB/usnic: Convert to use new iommu_capable() API function Date: Wed, 17 Sep 2014 10:30:53 +0200 Message-ID: <20140917083053.GD2533@suse.de> References: <1409914384-21191-1-git-send-email-joro@8bytes.org> <1409914384-21191-12-git-send-email-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1409914384-21191-12-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi, On Fri, Sep 05, 2014 at 12:53:03PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Cc: Upinder Malhi > Signed-off-by: Joerg Roedel > --- > drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c > index 801a1d6..417de1f 100644 > --- a/drivers/infiniband/hw/usnic/usnic_uiom.c > +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c > @@ -507,7 +507,7 @@ int usnic_uiom_attach_dev_to_pd(struct usnic_uiom_pd *pd, struct device *dev) > if (err) > goto out_free_dev; > > - if (!iommu_domain_has_cap(pd->domain, IOMMU_CAP_CACHE_COHERENCY)) { > + if (!iommu_capable(dev->bus, IOMMU_CAP_CACHE_COHERENCY)) { > usnic_err("IOMMU of %s does not support cache coherency\n", > dev_name(dev)); > err = -EINVAL; Any objections against this? I would like to apply this series to the iommu tree. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754808AbaIQIa6 (ORCPT ); Wed, 17 Sep 2014 04:30:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53804 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbaIQIa4 (ORCPT ); Wed, 17 Sep 2014 04:30:56 -0400 Date: Wed, 17 Sep 2014 10:30:53 +0200 From: Joerg Roedel To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Upinder Malhi Subject: Re: [PATCH 11/12] IB/usnic: Convert to use new iommu_capable() API function Message-ID: <20140917083053.GD2533@suse.de> References: <1409914384-21191-1-git-send-email-joro@8bytes.org> <1409914384-21191-12-git-send-email-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409914384-21191-12-git-send-email-joro@8bytes.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Sep 05, 2014 at 12:53:03PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Cc: Upinder Malhi > Signed-off-by: Joerg Roedel > --- > drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c > index 801a1d6..417de1f 100644 > --- a/drivers/infiniband/hw/usnic/usnic_uiom.c > +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c > @@ -507,7 +507,7 @@ int usnic_uiom_attach_dev_to_pd(struct usnic_uiom_pd *pd, struct device *dev) > if (err) > goto out_free_dev; > > - if (!iommu_domain_has_cap(pd->domain, IOMMU_CAP_CACHE_COHERENCY)) { > + if (!iommu_capable(dev->bus, IOMMU_CAP_CACHE_COHERENCY)) { > usnic_err("IOMMU of %s does not support cache coherency\n", > dev_name(dev)); > err = -EINVAL; Any objections against this? I would like to apply this series to the iommu tree. Joerg