From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUDWM-0006Qw-GV for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUDWH-0001uY-Ay for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:35:38 -0400 Received: from dew.nodalink.com ([95.130.14.197]:56396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUDWG-0001uF-UW for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:35:33 -0400 Date: Wed, 17 Sep 2014 11:35:34 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140917113534.GC21222@nodalink.com> References: <1410891148-28849-1-git-send-email-armbru@redhat.com> <1410891148-28849-14-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410891148-28849-14-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, benoit.canet@nodalink.com > - if (size % dev->blk.conf.logical_block_size) { > + if (size % dev->conf.conf.logical_block_size) { This look strange (conf.conf) Anyway this seems correct. Reviewed-by: Benoit Canet