From: Bob Picco <bpicco@meloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH V2] sparc64: sun4v TLB error power off events
Date: Wed, 17 Sep 2014 12:24:23 +0000 [thread overview]
Message-ID: <20140917122423.GK17331@zareason> (raw)
In-Reply-To: <1410874007-11501-1-git-send-email-bpicco@meloft.net>
David Miller wrote: [Tue Sep 16 2014, 08:35:15PM EDT]
> From: David Miller <davem@davemloft.net>
> Date: Tue, 16 Sep 2014 20:16:51 -0400 (EDT)
>
> > Anyways, we have to figure out why 0x8 is set in the PTE that we try
> > to load into ITLB. I haven't found any smoking guns yet.
>
> Looking more closely, the PTE 0x2900000dcc800eeb doesn't even have
> the valid bit set.
Yes.
>
> Non-valid PTEs should not even get into the TSB, and non-valid PTEs
> found via page table lookup should vector us to the full fault path.
>
> There used to be a bug where we'd put non-valid TTEs into the TSB
> but that was fixed by commit:
>
> commit 18f38132528c3e603c66ea464727b29e9bbcb91b
> Author: David S. Miller <davem@davemloft.net>
> Date: Mon Aug 4 16:34:01 2014 -0700
>
> sparc64: Do not insert non-valid PTEs into the TSB hash table.
>
> Do you know if the kernels that triggered those ITLB BADRA errors had
> that fix or not?
I doubt it. I just checked my log for T4-2 and none of the kernels appears
close to this:
[bpicco@zareason linus.git]$ git describe --contains 18f38132528c3e603c66ea464727b29e9bbcb91b
v3.17-rc1~105^2~1^2~6
when the issue was revealed.
next prev parent reply other threads:[~2014-09-17 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 13:26 [PATCH V2] sparc64: sun4v TLB error power off events Bob Picco
2014-09-16 21:47 ` David Miller
2014-09-17 0:16 ` David Miller
2014-09-17 0:35 ` David Miller
2014-09-17 0:49 ` David Miller
2014-09-17 12:19 ` Bob Picco
2014-09-17 12:24 ` Bob Picco [this message]
2014-09-17 12:40 ` Bob Picco
2014-09-17 16:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917122423.GK17331@zareason \
--to=bpicco@meloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.