From: Florian Westphal <fw@strlen.de>
To: Cong Wang <cwang@twopensource.com>
Cc: Francesco Ruggeri <fruggeri@arista.com>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Weilong Chen <chenweilong@huawei.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: Cannot move macvlan interface on top of bonding device
Date: Wed, 17 Sep 2014 21:06:26 +0200 [thread overview]
Message-ID: <20140917190626.GA11354@breakpoint.cc> (raw)
In-Reply-To: <CAHA+R7O0LuvFujDnDjW-kcwG=9BGbaSBfO9GXhxD0ANLyeJLXQ@mail.gmail.com>
Cong Wang <cwang@twopensource.com> wrote:
> On Wed, Sep 17, 2014 at 8:56 AM, Francesco Ruggeri <fruggeri@arista.com> wrote:
> > This used to work in older releases.
> > The problem seems to be that commit f939981492 sets NETIF_F_NETNS_LOCAL
> > on bonding interfaces, and commit 797f87f83 causes macvlan interfaces
> > to inherit its features from the lower device.
> >
> > Is there a reason why NETIF_F_NETNS_LOCAL should be inherited from the
> > lower device
> > by macvlan interfaces?
>
> commit 797f87f83 looks wrong, it should not inherit NETIF_F_NETNS_LOCAL,
> so just clear this flag. Please submit a patch.
Under which conditions would NETIF_F_NETNS_LOCAL have to be inherited?
(i.e., why is it inheritable in the first place?)
next prev parent reply other threads:[~2014-09-17 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 15:56 Cannot move macvlan interface on top of bonding device Francesco Ruggeri
2014-09-17 16:46 ` Cong Wang
2014-09-17 19:06 ` Florian Westphal [this message]
2014-09-17 20:25 ` Cong Wang
2014-09-17 20:39 ` Vlad Yasevich
2014-09-17 20:46 ` Cong Wang
2014-09-17 20:49 ` Francesco Ruggeri
2014-09-17 20:51 ` Vlad Yasevich
2014-09-17 21:28 ` Florian Westphal
-- strict thread matches above, loose matches on Subject: below --
2014-09-18 17:36 Francesco Ruggeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917190626.GA11354@breakpoint.cc \
--to=fw@strlen.de \
--cc=chenweilong@huawei.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=fruggeri@arista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.