From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: ssbi: promote the driver to subsys level Date: Wed, 17 Sep 2014 15:25:19 -0700 Message-ID: <20140917222519.GV30918@lee--X1> References: <1410915594-15599-1-git-send-email-srinivas.kandagatla@linaro.org> <20140917160305.GH30918@lee--X1> <20140917164925.GO30918@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f177.google.com ([209.85.213.177]:50725 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756584AbaIQWZX (ORCPT ); Wed, 17 Sep 2014 18:25:23 -0400 Received: by mail-ig0-f177.google.com with SMTP id uq10so133960igb.10 for ; Wed, 17 Sep 2014 15:25:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140917164925.GO30918@lee--X1> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: linux-arm-msm , Samuel Ortiz , Daniel Walker , David Brown , linux-kernel@vger.kernel.org On Wed, 17 Sep 2014, Lee Jones wrote: > On Wed, 17 Sep 2014, Srinivas Kandagatla wrote: >=20 > > On 17 Sep 2014 09:03, "Lee Jones" wrote: > > > > > > On Wed, 17 Sep 2014, Srinivas Kandagatla wrote: > > > > > > > This patch promtes the driver to be at subsystem level as this = driver > > > > will be used by gpio controller drivers which inturn are used b= y many > > > > platform drivers. > > > > > > Any reason why you're not using -EPROBE? > > > > > EPROBE is possible but it's going to add few more cycles to boot ti= me. > >=20 > > As this driver is a very basic driver on which other drivers depend > > ensuring the sequence would improve the boot time. >=20 > We only tend to promote drivers' init level as a last resort. If > -EPROBE_DEFER is possible, please use that instead. To conclude for any casual/interested observers; I'd be willing to accept the patch if you can provide some metrics that prove boot-time is sufficiently increased as a result of using -EPROBE_DEFER. > > > > Signed-off-by: Srinivas Kandagatla > > > > --- > > > > drivers/mfd/ssbi.c | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c > > > > index b78942e..4fbe02e 100644 > > > > --- a/drivers/mfd/ssbi.c > > > > +++ b/drivers/mfd/ssbi.c > > > > @@ -331,7 +331,12 @@ static struct platform_driver ssbi_driver = =3D { > > > > .of_match_table =3D ssbi_match_table, > > > > }, > > > > }; > > > > -module_platform_driver(ssbi_driver); > > > > + > > > > +static int ssbi_init(void) > > > > +{ > > > > + return platform_driver_register(&ssbi_driver); > > > > +} > > > > +subsys_initcall(ssbi_init); Also, as a nasty side-effect of this patch, this module will no longer be unloadable, which is probably not what you want. > > > > MODULE_LICENSE("GPL v2"); > > > > MODULE_VERSION("1.0"); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog