From: Samuel Ortiz <samuel.ortiz@intel.com>
To: Mika Westerberg <mika.westerberg@intel.com>
Cc: Loic Poulain <loic.poulain@intel.com>,
linus.walleij@linaro.org, heikki.krogerus@linux.intel.com,
mathias.nyman@linux.intel.com, linux-kernel@vger.kernel.org,
Eric Ernst <eric.ernst@linux.intel.com>
Subject: Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit
Date: Thu, 18 Sep 2014 11:41:13 +0200 [thread overview]
Message-ID: <20140918094113.GC26004@zurbaran> (raw)
In-Reply-To: <20140918074910.GC10854@lahna.fi.intel.com>
Hi Mika,
On Thu, Sep 18, 2014 at 10:49:43AM +0300, Mika Westerberg wrote:
> On Wed, Sep 17, 2014 at 03:47:01PM +0200, Loic Poulain wrote:
> > Direct Irq En bit can be initialized to a bad value.
> > This bit has to be cleared for io access mode.
>
> +Eric
>
> I would like to have a bit better explanation *why* this bit needs to be
> cleared.
>
> Also want to ask Eric (who added the WARN()), is there something
> preventing us to do this? I remember last time you said that we are not
> supposed to change this bit runtime.
>
> My preference is that we get rid of the WARN() and just unconditionally
> clear the bit.
I'd keep the warn though, as it most likely shows a buggy firmware
implementation.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2014-09-18 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 13:47 [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit Loic Poulain
2014-09-18 7:49 ` Mika Westerberg
2014-09-18 9:31 ` Loic Poulain
2014-09-18 9:53 ` Mika Westerberg
2014-09-18 9:41 ` Samuel Ortiz [this message]
2014-09-18 9:55 ` Mika Westerberg
2014-09-18 23:59 ` eric ernst
2014-09-23 15:44 ` Linus Walleij
2014-09-23 18:36 ` Westerberg, Mika
2014-09-24 8:44 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918094113.GC26004@zurbaran \
--to=samuel.ortiz@intel.com \
--cc=eric.ernst@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.