All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Picco <bpicco@meloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc64: swapper_tsb and swapper_4m_tsb phys correction
Date: Thu, 18 Sep 2014 21:34:44 +0000	[thread overview]
Message-ID: <20140918213444.GT17331@zareason> (raw)
In-Reply-To: <1410886239-15774-1-git-send-email-bpicco@meloft.net>

Hi,
David Miller wrote:	[Thu Sep 18 2014, 01:08:08PM EDT]
> From: Bob Picco <bpicco@meloft.net>
> Date: Thu, 18 Sep 2014 06:09:12 -0400
> 
> > The machine hung after remapping. It could have been my mistake. Please
> > let me investigate.
> 
> I was hoping this would have been the simplest of the patches :-)
> 
> If you get stuck just print some debugging information with
> prom_printf() (the physical address of the KTSB, and the final
> instruction values after patching) then prom_halt() so it doesn't hang
> and you can reset more quickly.
> 
Sorry I was being yanked all over the place today. This boots on T5-2.
Now I'll look at your second version.


diff -u b/arch/sparc/include/asm/tsb.h b/arch/sparc/include/asm/tsb.h
--- b/arch/sparc/include/asm/tsb.h
+++ b/arch/sparc/include/asm/tsb.h
@@ -259,7 +259,7 @@
 	.section	.swapper_tsb_phys_patch, "ax"; \
 	.word		661b; \
 	.previous; \
-	sllx		REG1, 32, REG1; \
+	sllx		REG1, 22, REG1; \
 	or		REG1, REG2, REG1; \
 	srlx		VADDR, PAGE_SHIFT, REG2; \
 	and		REG2, (KERNEL_TSB_NENTRIES - 1), REG2; \
@@ -280,7 +280,7 @@
 	.section	.swapper_4m_tsb_phys_patch, "ax"; \
 	.word		661b; \
 	.previous; \
-	sllx		REG1, 32, REG1; \
+	sllx		REG1, 22, REG1; \
 	or		REG1, REG2, REG1; \
 	and		TAG, (KERNEL_TSB4M_NENTRIES - 1), REG2; \
 	sllx		REG2, 4, REG2; \

  parent reply	other threads:[~2014-09-18 21:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 16:50 [PATCH] sparc64: swapper_tsb and swapper_4m_tsb phys correction Bob Picco
2014-09-17  1:48 ` David Miller
2014-09-17 12:42 ` Bob Picco
2014-09-17 17:16 ` David Miller
2014-09-17 19:22 ` Bob Picco
2014-09-17 20:04 ` David Miller
2014-09-17 21:00 ` Bob Picco
2014-09-18 10:09 ` Bob Picco
2014-09-18 17:08 ` David Miller
2014-09-18 19:43 ` David Miller
2014-09-18 21:34 ` Bob Picco [this message]
2014-09-18 22:15 ` Bob Picco
2014-09-18 23:16 ` David Miller
2014-09-19 19:28 ` David Miller
2014-09-19 19:57 ` Bob Picco
2014-09-22  4:22 ` David Miller
2014-09-22 18:56 ` Bob Picco
2014-09-22 19:13 ` David Miller
2014-09-24 22:26 ` David Miller
2014-09-24 23:12 ` Bob Picco
2014-09-25 17:43 ` Bob Picco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140918213444.GT17331@zareason \
    --to=bpicco@meloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.