From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xen.org
Subject: Re: missing dependency to compat/xen.h
Date: Fri, 19 Sep 2014 11:28:48 +0200 [thread overview]
Message-ID: <20140919092848.GA23249@aepfle.de> (raw)
In-Reply-To: <54198E130200007800035A72@mail.emea.novell.com>
On Wed, Sep 17, Jan Beulich wrote:
> >>> On 17.09.14 at 13:01, <olaf@aepfle.de> wrote:
> > How is compat/xen.h supposed to be created?
> This make rule
>
> $(TARGET): delete-unfresh-files
> $(MAKE) -C tools
> $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h
> [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm
> $(MAKE) -f $(BASEDIR)/Rules.mk -C include
> $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s
> $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
> $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $(TARGET)
>
> is - afaict - guaranteeing that the include/compat/ generation
> happens before that of asm-offsets.s.
I had a change like shown below, which confused the xen build. Meanwhile
I found a way to achive my goal without such a change by reusing the
existing .phony target.
Olaf
--- a/Config.mk
+++ b/Config.mk
@@ -167,6 +167,9 @@ define move-if-changed
if ! cmp -s $(1) $(2); then mv -f $(1) $(2); else rm -f $(1); fi
endef
+.PHONY: FORCE
+FORCE:
+
buildmakevars2file = $(eval $(call buildmakevars2file-closure,$(1)))
define buildmakevars2file-closure
.PHONY: genpath
prev parent reply other threads:[~2014-09-19 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 11:01 missing dependency to compat/xen.h Olaf Hering
2014-09-17 11:35 ` Jan Beulich
2014-09-19 9:28 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919092848.GA23249@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.