From: Aaron Tomlin <atomlin@redhat.com>
To: mingo@kernel.org
Cc: Chuck Ebbert <cebbert.lkml@gmail.com>,
Helge Deller <deller@gmx.de>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-metag <linux-metag@vger.kernel.org>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP
Date: Fri, 19 Sep 2014 14:34:15 +0100 [thread overview]
Message-ID: <20140919133415.GG25400@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <541C11C1.2060105@imgtec.com>
On Fri, Sep 19, 2014 at 12:21:37PM +0100, James Hogan wrote:
> Hi Chuck,
>
> On 16/09/14 08:37, Chuck Ebbert wrote:
> > static inline unsigned long *end_of_stack(struct task_struct *p)
> > {
> > +#ifdef CONFIG_STACK_GROWSUP
> > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1;
>
> Nit: this line should probably be wrapped to 80 columns.
>
> Other than that, I've tested this on metag and can confirm that it fixes
> the following BUG which you would otherwise get during boot with Aaron's
> patches:
>
> BUG: failure at kernel/sched/core.c:2664/schedule_debug()!
> Kernel panic - not syncing: BUG!
>
> Tested-by: James Hogan <james.hogan@imgtec.com> [metag]
> Acked-by: James Hogan <james.hogan@imgtec.com>
OK.
Acked-by: Aaron Tomlin <atomlin@redhat.com>
> Aaron: please can you try to get this patch applied before your patch
> series.
Ingo,
I hope it's not too late to get this patch in (once the nit has been
addressed) for CONFIG_STACK_GROWSUP?
Regards,
--
Aaron Tomlin
prev parent reply other threads:[~2014-09-19 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 7:37 [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP Chuck Ebbert
2014-09-19 11:21 ` James Hogan
2014-09-19 11:21 ` James Hogan
2014-09-19 13:34 ` Aaron Tomlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919133415.GG25400@atomlin.usersys.redhat.com \
--to=atomlin@redhat.com \
--cc=cebbert.lkml@gmail.com \
--cc=deller@gmx.de \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.