From: Aaron Tomlin <atomlin@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
bmr@redhat.com, jcastillo@redhat.com, mguzik@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] fs: Use a seperate wq for do_sync_work() to avoid a potential deadlock
Date: Fri, 19 Sep 2014 16:44:23 +0100 [thread overview]
Message-ID: <20140919154423.GH25400@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <20140917211613.GU4322@dastard>
On Thu, Sep 18, 2014 at 07:16:13AM +1000, Dave Chinner wrote:
> > - Both lru_add_drain and do_sync_work work items are added to
> > the same global system_wq
> >
> > - The current work fn on the system_wq is do_sync_work and is
> > blocked waiting to aquire an sb's s_umount for reading
> >
> > - The umount task is the current owner of the s_umount in
> > question but is waiting for do_sync_work to continue.
> > Thus we hit a deadlock situation.
>
> What kernel did you see this deadlock on?
Sorry for the noise. This deadlock was produced under a kernel whereby
the workqueue implementation is significantly less sophisticated.
--
Aaron Tomlin
next prev parent reply other threads:[~2014-09-19 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 11:39 [RFC PATCH] fs: Use a seperate wq for do_sync_work() to avoid a potential deadlock Aaron Tomlin
2014-09-17 18:22 ` Oleg Nesterov
2014-09-17 20:46 ` Aaron Tomlin
2014-09-17 21:16 ` Dave Chinner
2014-09-19 15:44 ` Aaron Tomlin [this message]
2014-09-17 21:42 ` Oleg Nesterov
2014-09-19 9:35 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919154423.GH25400@atomlin.usersys.redhat.com \
--to=atomlin@redhat.com \
--cc=bmr@redhat.com \
--cc=david@fromorbit.com \
--cc=jcastillo@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.