From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] BR2_DEPRECATED: update option label and help
Date: Fri, 19 Sep 2014 22:04:52 +0200 [thread overview]
Message-ID: <20140919200452.GA4155@free.fr> (raw)
In-Reply-To: <1411134069-3327-1-git-send-email-gustavo@zacarias.com.ar>
Gustavo, All,
On 2014-09-19 10:41 -0300, Gustavo Zacarias spake thusly:
> We should use positive logic (show things that are otherwise hidden...)
> for the help since it's what it does.
> It also applies to more options than just packages alone, for example
> the AVR32 architecture so add an "options" label to it.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Except for a small comment, below...
> ---
> Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Config.in b/Config.in
> index 14ff55b..b494fab 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -301,9 +301,10 @@ config BR2_CCACHE_INITIAL_SETUP
> endif
>
> config BR2_DEPRECATED
> - bool "Show packages that are deprecated or obsolete"
> + bool "Show options and packages that are deprecated or obsolete"
> help
> - This option hides outdated/obsolete versions of packages.
> + This option shows outdated/obsolete versions of packages and
> + options that are hidden otherwise.
In English, adverbs are placed before the past participle, like you did
your commit log: ... otherwise hidden.
Regards,
Yann E. MORIN.
>
> if BR2_DEPRECATED
>
> --
> 1.8.5.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-09-19 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:41 [Buildroot] [PATCH] BR2_DEPRECATED: update option label and help Gustavo Zacarias
2014-09-19 20:04 ` Yann E. MORIN [this message]
2014-09-19 21:13 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919200452.GA4155@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.