All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/6] serial: add UniPhier serial driver
Date: Fri, 19 Sep 2014 21:15:36 +0900	[thread overview]
Message-ID: <20140919211536.96AC.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <CAPnjgZ00rv2umuYhmpTpQ0bhkTRsuyfJqFzqSd3Ev13kvY=qMA@mail.gmail.com>

Hi Simon,



On Fri, 5 Sep 2014 10:41:54 -0600
Simon Glass <sjg@chromium.org> wrote:
> Do you think we could use driver model instead? We have the serial
> infrastructure in place and I will likely merge it next week.
> 
> It moves the \r\n logic to a higher level.
> 
> It also removes the need for all the horrible #define stuff you have
> here to deal with multiple serial ports.




I am seeing serial_find_console_or_panic() func
in drivers/serial/serial-uclass.c


static void serial_find_console_or_panic(void)
{
	int node;

	/* Check for a chosen console */
	node = fdtdec_get_chosen_node(gd->fdt_blob, "stdout-path");
	if (node < 0)
		node = fdtdec_get_alias_node(gd->fdt_blob, "console");
	if (!uclass_get_device_by_of_offset(UCLASS_SERIAL, node, &cur_dev))
		return;

	/*
	 * If the console is not marked to be bound before relocation, bind
	 * it anyway.
	 */
	if (node > 0 &&
	    !lists_bind_fdt(gd->dm_root, gd->fdt_blob, node, &cur_dev)) {
		if (!device_probe(cur_dev))
			return;
		cur_dev = NULL;
	}





It looks like CONFIG_DM_SERIAL depends on CONFIG_OF_CONTROL.


UniPhier SoCs do not support device tree control.
Is the driver model serial still available?
What will happen if gd->fdt_blob is not set?



Best Regards
Masahiro Yamada

  parent reply	other threads:[~2014-09-19 12:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05  5:50 [U-Boot] [PATCH v4 0/6] Add support for Panasonic UniPhier SoCs/boards Masahiro Yamada
2014-09-05  5:50 ` [U-Boot] [PATCH v4 1/6] nand: denali: add Denali NAND driver for SPL Masahiro Yamada
2014-09-12  7:09   ` Chin Liang See
2014-09-12  8:06     ` Masahiro Yamada
2014-09-15  6:39       ` Chin Liang See
2014-09-17  9:09         ` Masahiro Yamada
2014-09-17 12:10           ` Chin Liang See
2014-09-05  5:50 ` [U-Boot] [PATCH v4 2/6] serial: add UniPhier serial driver Masahiro Yamada
2014-09-05 10:35   ` Marek Vasut
2014-09-05 12:03     ` Masahiro Yamada
2014-09-05 12:59       ` Marek Vasut
2014-09-05 16:41       ` Simon Glass
2014-09-06 14:49         ` Masahiro YAMADA
2014-09-19 12:15         ` Masahiro Yamada [this message]
2014-09-19 16:30           ` Simon Glass
2014-09-20  7:18             ` Masahiro YAMADA
2014-09-22  6:35               ` Simon Glass
2014-09-05  5:50 ` [U-Boot] [PATCH v4 3/6] arm: uniphier: add UniPhier SoC support code Masahiro Yamada
2014-09-05 18:59   ` Simon Glass
2014-09-06 15:34     ` Masahiro YAMADA
2014-09-06 16:39       ` Simon Glass
2014-09-05  5:50 ` [U-Boot] [PATCH v4 4/6] arm: uniphier: add Kconfig and defconfig Masahiro Yamada
2014-09-05  5:50 ` [U-Boot] [PATCH v4 5/6] MAINTAINERS: add me as a maintainer of UniPhier platform Masahiro Yamada
2014-09-18 11:33   ` Albert ARIBAUD
2014-09-18 11:40     ` Michal Simek
2014-09-05  5:50 ` [U-Boot] [PATCH v4 6/6] git-mailrc: " Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140919211536.96AC.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.