From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Outcome of the GSoC 2014
Date: Sat, 20 Sep 2014 13:11:30 +0200 [thread overview]
Message-ID: <20140920131130.1cab6f32@free-electrons.com> (raw)
In-Reply-To: <20140919222504.GA19421@itchy>
Dear Eric Le Bihan,
On Sat, 20 Sep 2014 00:25:04 +0200, Eric Le Bihan wrote:
> I have reworked the patch:
>
> - introduction of pkg-config-native in host-pkgconf.
> - addition of a dependency on host-pkgconf to host-libgtk3.
> - addition of multiple backend support (X11/Wayland/Broadway) in libgtk3.
Looks good. Make sure to have a separate patch for pkg-config-native.
> When one adopts a patch, how should the credits be edited? Do I keep the
> original author of the patch in the commit log and add myself in a
> "Signed-off-by" line with some comments, or vice-versa?
Normally, you keep the original author as the author of the patch, add
a new SoB line with your name, and do something like:
[Eric: added this, and that, etc.]
To indicate the changes you've made to the original patch.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-09-20 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 19:44 [Buildroot] Outcome of the GSoC 2014 Thomas Petazzoni
2014-09-15 21:13 ` Eric Le Bihan
2014-09-15 21:16 ` Thomas Petazzoni
2014-09-19 22:25 ` Eric Le Bihan
2014-09-20 10:24 ` Yann E. MORIN
2014-09-20 11:11 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920131130.1cab6f32@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.