All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Mathias Krause <minipli@googlemail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH 2/3] x86, ptdump: Simplify page flag evaluation code
Date: Sun, 21 Sep 2014 09:05:24 +0200	[thread overview]
Message-ID: <20140921070524.GA10827@gmail.com> (raw)
In-Reply-To: <1411248142-28951-3-git-send-email-minipli@googlemail.com>


* Mathias Krause <minipli@googlemail.com> wrote:

> -#define pt_dump_seq_printf(m, to_dmesg, fmt, args...)		\
> +#define ptd_print(m, to_dmesg, fmt, args...)			\

Please don't abbreviate to non-obvious shortcuts ('ptd'), keep 
using the pt_dump_ prefix which was just fine.

(If checkpatch complains about lines slightly above 80cols then 
ignore checkpatch, don't uglify the code.)

Thanks,

	Ingo

  reply	other threads:[~2014-09-21  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20 21:22 [PATCH 0/3] x86, ptdump: a EFI related fix + enhancements Mathias Krause
2014-09-20 21:22 ` [PATCH 1/3] x86, ptdump: Add section for EFI runtime services Mathias Krause
2014-09-20 21:22 ` [PATCH 2/3] x86, ptdump: Simplify page flag evaluation code Mathias Krause
2014-09-21  7:05   ` Ingo Molnar [this message]
2014-09-20 21:22 ` [PATCH 3/3] x86, ptdump: Take parent page flags into account Mathias Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140921070524.GA10827@gmail.com \
    --to=mingo@kernel.org \
    --cc=arjan@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=minipli@googlemail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.