From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVjdu-0006s5-67 for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 12:05:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVjdj-0006r1-7R for grub-devel@gnu.org; Sun, 21 Sep 2014 12:05:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVjdY-0005l5-Js for grub-devel@gnu.org; Sun, 21 Sep 2014 12:05:31 -0400 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:60615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVjdY-0005kn-Cb for grub-devel@gnu.org; Sun, 21 Sep 2014 12:05:20 -0400 Received: by mail-lb0-f174.google.com with SMTP id l4so5408784lbv.5 for ; Sun, 21 Sep 2014 09:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=G2CXn28ryI5Y90uHS7zjQqxOsZvDeF7girkbZd5JGcg=; b=gjM+9nyMmjdKnTsRXCtDnRJfEsSlT9zRAwqTZjK+y8LryBStc76XmOZibBwgPzaDHq S+tYFkADMOwMzPKU0+wZpAwdGPBkQko18yuYhj6vNYKVXJlxUbWVcy+UYZIZ1RMCmzCM d2QG/kH+2KTy7Q1951K9HKsvg9zparhrlsyShDM/vv1+db4ZMoy9IL4OlcuRr/HdJNr1 sRXoW80kEsEIziwjUVmorBOcFluXXUKfBSBcWB7lIb3+pBTbDq72nMllNzU9co2EZQLO i9A2H0bYcn0Wgg8UKgFdC09xVaiwMmJP0kzolgNiVTXl46FMOfD7y57RENvmaXWSKxsc GGRA== X-Received: by 10.112.210.197 with SMTP id mw5mr19338935lbc.20.1411315133770; Sun, 21 Sep 2014 08:58:53 -0700 (PDT) Received: from opensuse.site (ppp94-29-94-89.pppoe.spdop.ru. [94.29.94.89]) by mx.google.com with ESMTPSA id pw9sm2812526lbb.2.2014.09.21.08.58.52 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 21 Sep 2014 08:58:52 -0700 (PDT) Date: Sun, 21 Sep 2014 19:58:48 +0400 From: Andrei Borzenkov To: The development of GNU GRUB Subject: Re: [PATCH] Fix extraous comma in printf Message-ID: <20140921195848.75ed2a17@opensuse.site> In-Reply-To: <541EF38F.4050305@gmail.com> References: <1410431234-26472-1-git-send-email-mchang@suse.com> <541EF38F.4050305@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.23; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/2aUUM9KqCHfBuzksUUfXzx7"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 16:05:40 -0000 --Sig_/2aUUM9KqCHfBuzksUUfXzx7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sun, 21 Sep 2014 17:49:35 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > Committed, thanks. You commit contains much more than this single line. Is it intentional? > On 11.09.2014 12:27, Michael Chang wrote: > > This patch is to get intended output from printf shell command, as the > > comma is not used as separator for it's arguments, they will eventually > > be outputted together with the variables. > >=20 > > Though it does not affect or break any function currently, I'd like to > > address this hidden problem and hope to get some attention of it. > >=20 > > Thanks. > > --- > > grub-core/osdep/unix/config.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/grub-core/osdep/unix/config.c b/grub-core/osdep/unix/confi= g.c > > index f4b0bb4..65effa9 100644 > > --- a/grub-core/osdep/unix/config.c > > +++ b/grub-core/osdep/unix/config.c > > @@ -105,8 +105,8 @@ grub_util_load_config (struct grub_util_config *cfg) > > *ptr++ =3D *iptr; > > } > > =20 > > - strcpy (ptr, "'; printf \"GRUB_ENABLE_CRYPTODISK=3D%s\\nGRUB_DISTRIB= UTOR=3D%s\\n\", " > > - "\"$GRUB_ENABLE_CRYPTODISK\", \"$GRUB_DISTRIBUTOR\""); > > + strcpy (ptr, "'; printf \"GRUB_ENABLE_CRYPTODISK=3D%s\\nGRUB_DISTRIB= UTOR=3D%s\\n\" " > > + "\"$GRUB_ENABLE_CRYPTODISK\" \"$GRUB_DISTRIBUTOR\""); > > =20 > > argv[2] =3D script; > > argv[3] =3D '\0'; > >=20 >=20 >=20 --Sig_/2aUUM9KqCHfBuzksUUfXzx7 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlQe9boACgkQR6LMutpd94wVywCcC8C5E3NfgiXmbwP+ovynZynq kjkAn1BKaEnEVbnHc0havV+Qi0v1fC2N =bFH2 -----END PGP SIGNATURE----- --Sig_/2aUUM9KqCHfBuzksUUfXzx7--