All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: linux@horizon.com
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC] mke2fs -E hash_alg=siphash: any interest?
Date: Sun, 21 Sep 2014 21:17:06 -0400	[thread overview]
Message-ID: <20140922011706.GC30646@thunk.org> (raw)
In-Reply-To: <20140921210416.27127.qmail@ns.horizon.com>

On Sun, Sep 21, 2014 at 05:04:16PM -0400, linux@horizon.com wrote:
> One things I'm coming across immediately that I have to ask for
> design guidance on is the hash algorithm number assignment:
> 
> - Should I leave room for more hashes with a signed/unsigned distinction,
>   or should I assume that's a historical kludge that won't be perpetuated?
>   SipHash is defined on a byte string, so there isn't really a signed
>   version.

It's a historical kludge that shouldn't be needed for new checksums;
just make sure it is defined correctly and that you test interop
between Big-Endian and Little-Endian machines.  The awfulness we had
was because there were already a large number of file systems out in
the field on PowerPC and Intel machines, so we needed to preserve
compatibility as much as possible, such that newer kernels could
correctly understand filesystems that had originally been created on
the opposite-endian system.

Cheers,

						- Ted

  parent reply	other threads:[~2014-09-22  1:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21  9:53 [RFC] mke2fs -E hash_alg=siphash: any interest? George Spelvin
2014-09-21 17:55 ` Theodore Ts'o
2014-09-21 21:04   ` linux
2014-09-21 22:08     ` TR Reardon
2014-09-22  2:31       ` George Spelvin
2014-09-22 17:09         ` Theodore Ts'o
2014-09-22 23:14           ` George Spelvin
2014-09-22  1:17     ` Theodore Ts'o [this message]
2014-09-23 22:25   ` Andreas Dilger
2014-09-23 23:00     ` George Spelvin
2014-09-23 23:22       ` Theodore Ts'o
2014-09-24  0:37         ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140922011706.GC30646@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.