All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>, devel@lists.open80211s.org
Cc: linux-wireless@vger.kernel.org,
	Ashok Nagarajan <ashok.dragon@gmail.com>,
	johannes@sipsolutions.net
Subject: Re: [PATCH v3 1/2] iw: Allow user to provide freq during mesh join
Date: Mon, 22 Sep 2014 07:00:16 -0400	[thread overview]
Message-ID: <20140922110016.GA302@localhost> (raw)
In-Reply-To: <1411195244-9130-1-git-send-email-yeohchunyeow@gmail.com>

On Sat, Sep 20, 2014 at 02:40:43PM +0800, Chun-Yeow Yeoh via Devel wrote:
> +	/* freq */
> +	if (argc > 1 && strcmp(argv[0], "freq") == 0) {
> +		argv++;
> +		argc--;

[snip]

> -COMMAND(mesh, join, "<mesh ID> [mcast-rate <rate in Mbps>]"
> +COMMAND(mesh, join, "<mesh ID> [freq in MHz] [HT20|HT40+|HT40-|NOHT]"

Should this be something like:

> +COMMAND(mesh, join, "<mesh ID> [freq <freq in MHz> <HT20|HT40+|HT40-|NOHT>]"

...so we know to specify the 'freq' keyword?

-- 
Bob Copeland %% www.bobcopeland.com

  parent reply	other threads:[~2014-09-22 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20  6:40 [PATCH v3 1/2] iw: Allow user to provide freq during mesh join Chun-Yeow Yeoh
2014-09-20  6:40 ` [PATCH v3 2/2] iw: Allow basic rates to be configured when joining mesh Chun-Yeow Yeoh
2014-09-22 11:00 ` Bob Copeland [this message]
2014-09-22 12:50   ` [PATCH v3 1/2] iw: Allow user to provide freq during mesh join Yeoh Chun-Yeow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140922110016.GA302@localhost \
    --to=me@bobcopeland.com \
    --cc=ashok.dragon@gmail.com \
    --cc=devel@lists.open80211s.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yeohchunyeow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.