From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 29/89] drm/i915/skl: vfuncs for skl eld and
 global resource
Date: Mon, 22 Sep 2014 14:32:34 +0100
Message-ID: <20140922133234.GG10951@strange.ger.corp.intel.com>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-30-git-send-email-damien.lespiau@intel.com>
 <CABVU7+vtGqZ=h2m9byB3WfT0bncnoXzJobVFTC+dYA7jbM_4Yg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 26FF289E86
 for <intel-gfx@lists.freedesktop.org>; Mon, 22 Sep 2014 06:32:45 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CABVU7+vtGqZ=h2m9byB3WfT0bncnoXzJobVFTC+dYA7jbM_4Yg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 16, 2014 at 06:50:47PM -0700, Rodrigo Vivi wrote:
>    isn't fdi_link_training needed?

No, it's not. SKL doesn't have FDI.

-- 
Damien

>    if not: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>    On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <damien.lespiau@intel.com>
>    wrote:
> 
>      From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
> 
>      Set gen 9 function pointers for eld write and global resource.
>      Implementation remains same as HSW.
> 
>      v2: Rebase on top of Sonika's untangling of the if/else ladder (Damien)
> 
>      Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@intel.com> (v1)
>      Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>      ---
>       drivers/gpu/drm/i915/intel_display.c | 4 ++++
>       1 file changed, 4 insertions(+)
> 
>      diff --git a/drivers/gpu/drm/i915/intel_display.c
>      b/drivers/gpu/drm/i915/intel_display.c
>      index bffabfd..48d2d0d 100644
>      --- a/drivers/gpu/drm/i915/intel_display.c
>      +++ b/drivers/gpu/drm/i915/intel_display.c
>      @@ -12654,6 +12654,10 @@ static void intel_init_display(struct
>      drm_device *dev)
>                      dev_priv->display.modeset_global_resources =
>                              valleyview_modeset_global_resources;
>                      dev_priv->display.write_eld = ironlake_write_eld;
>      +       } else if (INTEL_INFO(dev)->gen >= 9) {
>      +               dev_priv->display.write_eld = haswell_write_eld;
>      +               dev_priv->display.modeset_global_resources =
>      +                       haswell_modeset_global_resources;
>              }
> 
>              /* Default just returns -ENODEV to indicate unsupported */
>      --
>      1.8.3.1
> 
>      _______________________________________________
>      Intel-gfx mailing list
>      Intel-gfx@lists.freedesktop.org
>      http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
>    --
>    Rodrigo Vivi
>    Blog: http://blog.vivi.eng.br
>