From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH] modified error code when perf_session__new() fail Date: Mon, 22 Sep 2014 15:46:16 +0200 Message-ID: <20140922134616.GC18187@krava.brq.redhat.com> References: <541946D8.1080209@gmail.com> <1411227895.1690.23.camel@leonhard> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18445 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753625AbaIVNqX (ORCPT ); Mon, 22 Sep 2014 09:46:23 -0400 Content-Disposition: inline In-Reply-To: <1411227895.1690.23.camel@leonhard> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Namhyung Kim Cc: taeung , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org On Sun, Sep 21, 2014 at 12:44:55AM +0900, Namhyung Kim wrote: > Hi Taeung, >=20 > Please CC perf maintainers when you send a perf patch. I'm adding > Arnaldo who maintains tooling part and Jiri who suggested this change= =2E >=20 >=20 > 2014-09-17 (=EC=88=98), 17:31 +0900, taeung: > > Hi, > >=20 > > I modified error code for the requirement as below. > >=20 > > Author: taeung > > Date: Sat Sep 13 16:22:53 2014 +0900 > >=20 > > modified error code when perf_session__new() fail > >=20 > > Because perf_session__new() could fail > > for more reasons than just ENOMEM, > > I modified error code(ENOMEM or EINVAL) > > into -1. >=20 > Hmm.. this seems you copied output of "git show" and send it via an > email client. I recommend you to use "git format-patch" and "git > send-email" later. yep, the patch is mangled.. also following doc might be useful: Documentation/email-clients.txt >=20 > In addition, you forgot to add your Signed-off-by. >=20 > That being said I'm okay with the patch itself. Jiri, this is what y= ou > wanted to do, right? I have some vague memories about this.. any link to refresh my memory? = ;-) but right, the change seems ok jirka