From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 45/89] drm/i915/skl: Definition of SKL WM
 param structs for pipe/plane
Date: Mon, 22 Sep 2014 15:21:22 +0100
Message-ID: <20140922142122.GN10951@strange.ger.corp.intel.com>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-46-git-send-email-damien.lespiau@intel.com>
 <20140922140610.GU12416@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8A91A6E42F
 for <intel-gfx@lists.freedesktop.org>; Mon, 22 Sep 2014 07:21:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140922140610.GU12416@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Pradeep Bhat <pradeep.bhat@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Sep 22, 2014 at 05:06:11PM +0300, Ville Syrj=E4l=E4 wrote:
> > +struct skl_pipe_wm {
> > +	struct skl_wm_level wm[8];
> > +	struct skl_wm_level trans_wm;
> > +	uint32_t linetime;
> > +};
> > +
> >  struct intel_crtc {
> >  	struct drm_crtc base;
> >  	enum pipe pipe;
> > @@ -431,9 +437,11 @@ struct intel_crtc {
> >  	bool pch_fifo_underrun_disabled;
> >  =

> >  	/* per-pipe watermark state */
> > -	struct {
> > +	union {
> =

> I almost gave my r-b, but then I noticed this. It's going to mess up my
> pending watermark series. I'm going to add tons of junk here, so union
> is not really acceptable for me. Needs some other solution.

Well, you could use an anonymous structure in that union? We could also
try to merge skl_pipe_wm and intel_pipe_wm at a later point? or just
leaving this a struct, wasting a tiny bit of memory be good enough for
now?

-- =

Damien