From: Peter Zijlstra <peterz@infradead.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"open list:X86 ARCHITECTURE..." <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()
Date: Mon, 22 Sep 2014 22:07:16 +0200 [thread overview]
Message-ID: <20140922200716.GB3128@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1411415590-12193-1-git-send-email-bobby.prani@gmail.com>
On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote:
> Use the much easier to read ACCESS_ONCE() which is basically the same thing as
> the cast to volatile.
>
> Please note the change in volatile cast: ACCESS_ONCE(v)->counter to
> ACCESS_ONCE(v->counter).
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/x86/include/asm/atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
If you want to do something like so, then be consistent and do them all.
next prev parent reply other threads:[~2014-09-22 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 19:53 [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read() Pranith Kumar
2014-09-22 20:07 ` Peter Zijlstra [this message]
2014-09-22 20:20 ` Pranith Kumar
2014-09-23 13:32 ` Pranith Kumar
2014-09-23 14:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922200716.GB3128@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bobby.prani@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.