From: Bjorn Helgaas <bhelgaas@google.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: mohit.kumar@st.com, jg1.han@samsung.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: designware: Use NULL instead of false
Date: Mon, 22 Sep 2014 14:54:26 -0600 [thread overview]
Message-ID: <20140922205426.GI1880@google.com> (raw)
In-Reply-To: <1411134450-806-1-git-send-email-fabio.estevam@freescale.com>
On Fri, Sep 19, 2014 at 10:47:30AM -0300, Fabio Estevam wrote:
> of_get_address() expects pointers in the third and fourth parameters.
>
> Pass NULL in order to fix the following sparse warnings:
>
> drivers/pci/host/pcie-designware.c:433:51: warning: Using plain integer as NULL pointer
> drivers/pci/host/pcie-designware.c:433:58: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied with acks from Lucas and Jingoo to pci/host-designware for v3.18,
thanks!
> ---
> drivers/pci/host/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 12c42fc..f1f0b7a 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -430,7 +430,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
>
> /* Find the untranslated configuration space address */
> index = of_property_match_string(np, "reg-names", "config");
> - addrp = of_get_address(np, index, false, false);
> + addrp = of_get_address(np, index, NULL, NULL);
> pp->cfg0_mod_base = of_read_number(addrp, ns);
> pp->cfg1_mod_base = pp->cfg0_mod_base + pp->config.cfg0_size;
> } else {
> --
> 1.9.1
>
prev parent reply other threads:[~2014-09-22 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:47 [PATCH] PCI: designware: Use NULL instead of false Fabio Estevam
2014-09-19 15:27 ` Lucas Stach
2014-09-22 9:26 ` Jingoo Han
2014-09-22 20:54 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922205426.GI1880@google.com \
--to=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=mohit.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.