From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWDia-0004We-Jx for qemu-devel@nongnu.org; Mon, 22 Sep 2014 20:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWDiS-000378-VI for qemu-devel@nongnu.org; Mon, 22 Sep 2014 20:12:32 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWDiS-00035c-Q7 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 20:12:24 -0400 Date: Tue, 23 Sep 2014 00:12:13 +0000 From: Serge Hallyn Message-ID: <20140923001213.GL8796@ubuntumail> References: <1411310339-27733-1-git-send-email-alex@alex.org.uk> <1411310339-27733-3-git-send-email-alex@alex.org.uk> <20140922113655.GI14882@redhat.com> <20140922114247.GE31563@redhat.com> <878ulb7k54.fsf@blackfin.pond.sub.org> <542043EA.6060104@redhat.com> <5420740D.1010700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Ryan Harper , Alexander Graf , "quintela@redhat.com" , Libvirt , "Michael S. Tsirkin" , Markus Armbruster , "qemu-devel@nongnu.org" , Amit Shah , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , "Serge E. Hallyn" Quoting Alex Bligh (alex@alex.org.uk): > > On 22 Sep 2014, at 20:10, Paolo Bonzini wrote: > > > I'm arguing against special-casing pc-1.0. Just apply the patch to > > Ubuntu downstream and call it a day. > > > > It's perfectly normal for machine types to be part of the downstream > > (not so secret) sauce. > > Well, I've just sent through a version that works as a machine > parameter instead. If upstream doesn't like this, I'd prefer > downstream took v2 of the patch (which makes -M pc-1.0 work) > instead. That's also what Serge tested. Yeah, prefer v2 as well. Sorry if that means wasted time on your part. Though I'm also thinking I prefer to have pc-1.0-precise defined in both precise's qemu-kvm 1.0, and later qemu 2.x, and requiring some purely-on-precise action to switch the machine type from pc-1.0 to pc-1.0-precise before migrating to trusty/later. But as I mentioned elsewhere there's still the concerns of (a) how much other still (like virito-net) will still break, and (b) the practical issues of how to ship the old roms. -serge