From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Joe Perches <joe@perches.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
shangw@linux.vnet.ibm.com
Subject: Re: [PATCH 0/2] powerpc: pci-ioda: Neatening
Date: Tue, 23 Sep 2014 10:53:39 +1000 [thread overview]
Message-ID: <20140923005339.GA7740@shangw> (raw)
In-Reply-To: <1411368977.16867.11.camel@concordia>
On Mon, Sep 22, 2014 at 04:56:17PM +1000, Michael Ellerman wrote:
>On Sun, 2014-09-21 at 10:55 -0700, Joe Perches wrote:
>> printk calls should return void
>>
>> Joe Perches (2):
>> powerpc: pci-ioda: Remove unnecessary return value from printk
>> powerpc: pci-ioda: Use a single function to emit logging messages
>
>Patches look good to me.
>
Patches look good to me too.
>Ben/Gavin, what do these macros give us over pr/dev_debug() ?
>
Those macros prints unified mapping information between
PE number and PCI device/bus.
Thanks,
Gavin
>cheers
>
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists.ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
prev parent reply other threads:[~2014-09-23 0:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 17:55 [PATCH 0/2] powerpc: pci-ioda: Neatening Joe Perches
2014-09-21 17:55 ` Joe Perches
2014-09-21 17:55 ` [PATCH 1/2] powerpc: pci-ioda: Remove unnecessary return value from printk Joe Perches
2014-09-21 17:55 ` Joe Perches
2014-09-21 17:55 ` [PATCH 2/2] powerpc: pci-ioda: Use a single function to emit logging messages Joe Perches
2014-09-21 17:55 ` Joe Perches
2014-09-22 6:56 ` [PATCH 0/2] powerpc: pci-ioda: Neatening Michael Ellerman
2014-09-22 6:56 ` Michael Ellerman
2014-09-23 0:53 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923005339.GA7740@shangw \
--to=gwshan@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.