All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Suketu Shah <suketu.j.shah@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: WaRsClearFWBitsAtReset - WA for blitter, render and media forcewake on BDW and GEN9 platforms.
Date: Tue, 23 Sep 2014 10:30:35 +0300	[thread overview]
Message-ID: <20140923073035.GW12416@intel.com> (raw)
In-Reply-To: <1411411382-4949-1-git-send-email-suketu.j.shah@intel.com>

On Mon, Sep 22, 2014 at 02:43:02PM -0400, Suketu Shah wrote:
> The newly loaded Gfx driver must first initialize the forcewake request register
> for render, media and blitter engines by clearing all forcewake bits (0xFFFF0000).
> This applies to BDW and GEN9 platforms.

Already done
intel_uncore_init()->intel_uncore_early_sanitize()->intel_uncore_forcewake_reset()

> 
> Change-Id: I633c530340a5918c084249a188d0397ed4f51a41
> Signed-off-by: Suketu Shah <suketu.j.shah@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_uncore.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index c9bf39e..9d94497 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1345,6 +1345,14 @@ void intel_uncore_init(struct drm_device *dev)
>  		dev_priv->uncore.funcs.mmio_readq  = gen4_read64;
>  		break;
>  	}
> +
> +	/* WaRsClearFWBitsAtReset: The newly loaded Gfx driver must first initialize the
> +	  * forcewake request register for render, media and blitter engines by clearing
> +	  * all forcewake bits (0xFFFF0000) on resets.
> +	  * This applies to BDW and Gen9 platforms.
> +	  */
> +	if (IS_BROADWELL(dev) || IS_GEN9(dev))
> +		intel_uncore_forcewake_reset(dev, false);
>  }
>  
>  void intel_uncore_fini(struct drm_device *dev)
> -- 
> 2.1.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2014-09-23  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 18:43 [PATCH] drm/i915: WaRsClearFWBitsAtReset - WA for blitter, render and media forcewake on BDW and GEN9 platforms Suketu Shah
2014-09-23  7:30 ` Ville Syrjälä [this message]
2014-09-25 18:18   ` Shah, Suketu J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923073035.GW12416@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=suketu.j.shah@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.