From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 25/46] Use configure --mandir=DIR to set
	MANDIR
Date: Tue, 23 Sep 2014 14:23:24 +0200
Message-ID: <20140923122324.GC10033@aepfle.de>
References: <1411390835-7348-1-git-send-email-olaf@aepfle.de>
	<1411390835-7348-26-git-send-email-olaf@aepfle.de>
	<1411464725.14989.29.camel@kazak.uk.xensource.com>
	<1411464989.14989.33.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1411464989.14989.33.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, David Scott <dave.scott@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, Sep 23, Ian Campbell wrote:

> Maybe we are just using it wrong and we should be doing in Paths.mk.in:
>         prefix=@prefix@
>         datarootdir=@datarootdir@
>         mandir=@mandir@
>         ...
>         MANDIR=\$mandir
> 
> (or even just switching our code to $mandir). Perhaps looking at what
> automake would put in Makefile.in for a generic project would be
> informative?
> 
> That would be a bigger change though and I'd be OK with deferring for
> now.

With automake the resulting variables are all lowercase. Perhaps thats
the reason why configure uses also lowercase. Just xen uses uppercase
for all variables.

So my options are either: expand to lowercase variables and assign to
existing uppercase variables later in that file. Or do a treewide
conversion from upper to lowercase.

Looks like the simplest change would be to expand all variables from
configure in Paths.mk and assign them later to existing variables.

Olaf