From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 32/46] Add configure
 --with-linux-backend-modules="mod1 mod2"
Date: Tue, 23 Sep 2014 14:41:03 +0200
Message-ID: <20140923124103.GF10033@aepfle.de>
References: <1411390835-7348-1-git-send-email-olaf@aepfle.de>
	<1411390835-7348-33-git-send-email-olaf@aepfle.de>
	<1411468138.14989.64.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1411468138.14989.64.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, David Scott <dave.scott@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, Sep 23, Ian Campbell wrote:

> On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > +LINUX_BACKEND_MODULES="`eval echo $LINUX_BACKEND_MODULES`"
> 
> Why does this need to be laundered via eval? There's no sensible way a
> user could want to pass in \$thing and expect it to expand to something
> useful, is there?

I decided to use a multiline assignment to make futher patches to the
content easier to read. If the variable is expanded it will appear as is
in the Makefile, resulting in syntax errors. Maybe a single echo would
work as well. 
Will check if this can be improved. But I fear there is not much that
can be done to achieve "\$thing".

Olaf