From: Josh Triplett <josh@joshtriplett.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"Rustad, Mark D" <mark.d.rustad@intel.com>,
"sparse@chrisli.org" <sparse@chrisli.org>,
"linux-sparse@vger.kernel.org" <linux-sparse@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] Silence even more W=2 warnings
Date: Tue, 23 Sep 2014 07:49:36 -0700 [thread overview]
Message-ID: <20140923144936.GA9844@thin> (raw)
In-Reply-To: <20140923080120.GA22072@pd.tnic>
On Tue, Sep 23, 2014 at 10:01:20AM +0200, Borislav Petkov wrote:
> ./arch/x86/include/asm/io_apic.h: In function ‘io_apic_modify’:
> ./arch/x86/include/asm/io_apic.h:223:48: warning: declaration of ‘apic’ shadows a global declaration [-Wshadow]
> static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned int value)
> ^
> In file included from ./arch/x86/include/asm/smp.h:12:0,
> from include/linux/smp.h:59,
> from include/linux/topology.h:33,
> from include/linux/gfp.h:8,
> from include/linux/kmod.h:22,
> from include/linux/module.h:13,
> from drivers/edac/amd64_edac.h:65,
> from drivers/edac/amd64_edac.c:1:
> ./arch/x86/include/asm/apic.h:366:21: warning: shadowed declaration is here [-Wshadow]
> extern struct apic *apic;
> ^
>
> So gcc complains that an unsigned int shadows a struct apic pointer.
Here, I think the right fix involves picking a more descriptive name
than "apic" for the global varible.
- Josh Triplett
next prev parent reply other threads:[~2014-09-23 14:49 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 15:29 [PATCH 0/7] Silence even more W=2 warnings Jeff Kirsher
2014-09-19 15:29 ` [PATCH 1/7] compiler: Add diagnostic control macros Jeff Kirsher
2014-09-19 15:29 ` [PATCH 2/7] x86: Silence initializer-overrides warnings Jeff Kirsher
2014-09-19 15:29 ` Jeff Kirsher
2014-09-19 15:29 ` [PATCH 3/7] atomic: Silence nested-externs warnings Jeff Kirsher
2014-09-19 20:43 ` Peter Zijlstra
2014-09-19 20:43 ` Peter Zijlstra
2014-09-19 20:53 ` Jeff Kirsher
2014-09-19 15:29 ` [PATCH 4/7] bitops: " Jeff Kirsher
2014-09-19 15:29 ` [PATCH 5/7] signal: " Jeff Kirsher
2014-09-19 15:35 ` Richard Weinberger
2014-09-19 15:37 ` Jeff Kirsher
2014-09-19 15:39 ` Richard Weinberger
2014-09-19 17:20 ` Oleg Nesterov
2014-09-19 21:21 ` Josh Triplett
2014-09-19 21:26 ` Rustad, Mark D
2014-09-21 16:42 ` [PATCH 0/1] signal: use BUILD_BUG() instead of _NSIG_WORDS_is_unsupported_size() Oleg Nesterov
2014-09-21 16:43 ` [PATCH 1/1] " Oleg Nesterov
2014-09-22 17:26 ` Josh Triplett
2014-09-19 15:29 ` [PATCH 6/7] mm: Silence nested-externs warnings Jeff Kirsher
2014-09-19 15:29 ` Jeff Kirsher
2014-09-19 15:29 ` [PATCH 7/7] sched: " Jeff Kirsher
2014-09-19 19:34 ` Richard Weinberger
2014-09-19 20:34 ` Rustad, Mark D
2014-09-19 20:41 ` Richard Weinberger
2014-09-19 20:49 ` Rustad, Mark D
2014-09-22 17:55 ` [PATCH] sched: Remove nested extern Mark D Rustad
2014-09-22 18:25 ` Josh Triplett
2014-09-22 19:01 ` Peter Zijlstra
2014-09-22 19:32 ` Rustad, Mark D
2014-09-22 20:05 ` Peter Zijlstra
2014-09-22 20:59 ` Rustad, Mark D
2014-09-22 21:21 ` Peter Zijlstra
2014-09-22 21:50 ` Rustad, Mark D
2014-09-24 7:41 ` Ingo Molnar
2014-09-24 7:52 ` Peter Zijlstra
2014-09-24 7:58 ` Ingo Molnar
2014-09-19 22:54 ` [PATCH 7/7] sched: Silence nested-externs warnings Peter Zijlstra
2014-09-19 23:26 ` Rustad, Mark D
2014-09-22 15:33 ` [PATCH 0/7] Silence even more W=2 warnings Borislav Petkov
2014-09-22 17:06 ` Rustad, Mark D
2014-09-22 18:40 ` Borislav Petkov
2014-09-22 18:59 ` Rustad, Mark D
2014-09-22 19:21 ` Borislav Petkov
2014-09-22 19:44 ` Jeff Kirsher
2014-09-22 19:57 ` Borislav Petkov
2014-09-22 20:09 ` Jeff Kirsher
2014-09-22 20:33 ` Borislav Petkov
2014-09-22 21:21 ` Jeff Kirsher
2014-09-23 8:01 ` Borislav Petkov
2014-09-23 8:01 ` Borislav Petkov
2014-09-23 14:49 ` Josh Triplett [this message]
2014-09-23 16:08 ` Borislav Petkov
2014-09-23 16:29 ` Rustad, Mark D
2014-09-25 7:45 ` Geert Uytterhoeven
2014-09-25 16:44 ` Borislav Petkov
2014-09-26 19:37 ` Rustad, Mark D
2014-09-26 19:58 ` josh
2014-09-26 21:07 ` Rustad, Mark D
2014-09-22 21:50 ` Rustad, Mark D
2014-09-23 8:22 ` Borislav Petkov
2014-09-23 17:24 ` Rustad, Mark D
2014-09-23 18:44 ` Borislav Petkov
2014-09-23 19:04 ` Joe Perches
2014-09-23 20:43 ` Rustad, Mark D
2014-09-25 8:27 ` Borislav Petkov
2014-09-25 0:17 ` Rustad, Mark D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923144936.GA9844@thin \
--to=josh@joshtriplett.org \
--cc=bp@alien8.de \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.