From: David Disseldorp <ddiss@suse.de>
To: Filipe Manana <fdmanana@suse.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests: btrfs: add test regarding clearing compression flag/property
Date: Tue, 23 Sep 2014 15:03:40 +0200 [thread overview]
Message-ID: <20140923150340.10e84449@linux-1mn8> (raw)
In-Reply-To: <1410432334-21796-1-git-send-email-fdmanana@suse.com>
On Thu, 11 Sep 2014 11:45:34 +0100, Filipe Manana wrote:
> Regression test for btrfs where removing the flag FS_COMPR_FL
> (chattr -c) from an inode wouldn't clear its compression property.
> This was fixed in the following linux kernel patch:
>
> Btrfs: add missing compression property remove in btrfs_ioctl_setflags
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
I would have expected this to fail with MOUNT_OPTIONS="-o compress=no",
but it looks as though Btrfs stores the attributes unconditionally.
Either way this change looks good to me.
Reviewed-by: David Disseldorp <ddiss@suse.de>
Cheers, David
prev parent reply other threads:[~2014-09-23 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 10:45 [PATCH] xfstests: btrfs: add test regarding clearing compression flag/property Filipe Manana
2014-09-23 13:03 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923150340.10e84449@linux-1mn8 \
--to=ddiss@suse.de \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.