From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbaIXAvj (ORCPT ); Tue, 23 Sep 2014 20:51:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39518 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbaIXAvi (ORCPT ); Tue, 23 Sep 2014 20:51:38 -0400 Date: Tue, 23 Sep 2014 17:51:37 -0700 From: Andrew Morton To: Peter Foley Cc: ashutosh dixit , Randy Dunlap , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "Dutt, Sudeep" , "Rao, Nikhil" , Greg Kroah-Hartman Subject: Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13 Message-Id: <20140923175137.aa87c1ea.akpm@linux-foundation.org> In-Reply-To: References: <5421EA22.6000206@infradead.org> <20140923163816.2f3cf938c7815424e55e444f@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Sep 2014 19:47:11 -0400 Peter Foley wrote: > On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton > wrote: > > This build error is caused by compiling mpssd prior to `make > > headers_install'. > > > > There's really no reason to check the kernel version. If someone > > transplants mpssd out of its distributed kernel and into some older > > kernel then a miscompile is their problem - their backport is > > incomplete. > > I've only noticed this error when running make Documentation/, > in which case gcc silently uses the headers from the system, > since the headers_install ones don't exist yet. > > Maybe having the build error out in this case instead of having mysterious > compile errors would be a better solution? > Can't we just fix the Makefiles? Cook up a rule which makes headers_install (if needed) before building Documentation/?