From: Josh Cartwright <joshc@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Pramod Gurav <pramod.gurav@smartplayin.com>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Josh Cartwright <joshc@codeaurora.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-pm@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff
Date: Tue, 23 Sep 2014 12:55:56 -0500 [thread overview]
Message-ID: <20140923175556.GG868@joshc.qualcomm.com> (raw)
In-Reply-To: <2C40727B-BF1E-46AC-9189-6B35E358220E@codeaurora.org>
On Tue, Sep 23, 2014 at 12:48:42PM -0500, Kumar Gala wrote:
>
> On Sep 23, 2014, at 1:28 AM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
>
> > +linux-arm-msm
> > On Tuesday 23 September 2014 11:38 AM, Pramod Gurav wrote:
> >> This change replaces use of arm_pm_restart with recently introduced
> >> reset mechanism in Linux kernel called restart_notifier.
>
> Can you update the commit message to include details about the priority level we are setting it to.
>
> Probably something like Josh had:
>
> Choose priority 128, as according to documentation, this mechanism "is
> sufficient to restart the entire system?.
>
> Hmm, what happens if we have ps_hold restart and msm-poweroff enabled.
> Which one should have priority?
I would hope we would avoid a situation where both this driver is
probed, and the pinctrl-msm driver has registered a restart handler?
That is, we wouldn't ever mix the pinctrl-msm ps_hold mechanism (for
MSM8660/MSM8960/APQ8064, etc) and msm-poweroff (APQ8074 and later). Is
this a case you're worried about?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-09-23 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 6:08 [PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff Pramod Gurav
2014-09-23 6:28 ` Pramod Gurav
2014-09-23 17:42 ` Stephen Boyd
2014-09-23 17:48 ` Kumar Gala
2014-09-23 17:55 ` Josh Cartwright [this message]
2014-09-23 18:20 ` Kumar Gala
2014-09-24 2:08 ` Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923175556.GG868@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pramod.gurav@smartplayin.com \
--cc=sboyd@codeaurora.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.