Re: [for master 3/6] ipumm-fw: Updated ipumm firmware for latest IPC version

[Denys Dmytriyenko <denys@ti.com>]

On Tue, Sep 23, 2014 at 02:05:30PM -0400, Cooper Jr., Franklin wrote:
> This looks like it really needs to be two separate recipes.  Maybe split out 
> the few common pieces in a .inc file and have machine specific stuff in 
> separate recipe files.
> 
> Currently everything is compatible with omap-a15 (SOC) but this build will 
> fail unless you are building for dra7xx or omap5-evm. So it probably will 
> make sense for the COMPATIBLE_MACHINE in the new recipes to depend on the 
> actual machine and not the SOC family.

Took me a bit to understand what you mean here. So, let me translate - the 
recipe is marked as compatible with entire omap-a15 SOC, but only handles 
cases for dra7xx-evm and omap5-evm machines. There are and will be more 
machines in this family, so either the recipe has to handle those machines 
too, or the compatibility setting should be stricter and list 2 machines 
instead of entire SOC family.


> > -----Original Message-----
> > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> > bounces@yoctoproject.org] On Behalf Of Dmytriyenko, Denys
> > Sent: Tuesday, September 23, 2014 11:22 AM
> > To: R, Karthik
> > Cc: meta-ti@yoctoproject.org
> > Subject: Re: [meta-ti] [for master 3/6] ipumm-fw: Updated ipumm firmware
> > for latest IPC version
> > 
> > On Tue, Sep 23, 2014 at 09:30:33PM +0530, Karthik Ramanan wrote:
> > > * This includes the error handling support.
> > > * Minor bug fixes
> > >
> > > Signed-off-by: Karthik Ramanan <a0393906@ti.com>
> > > ---
> > >  recipes-bsp/ipumm-fw/ipumm-fw_3.00.06.00.bb |   36
> > +++++++++++++++++++++++++++
> > >  1 file changed, 36 insertions(+)
> > >  create mode 100644 recipes-bsp/ipumm-fw/ipumm-fw_3.00.06.00.bb
> > >
> > > diff --git a/recipes-bsp/ipumm-fw/ipumm-fw_3.00.06.00.bb
> > > b/recipes-bsp/ipumm-fw/ipumm-fw_3.00.06.00.bb
> > > new file mode 100644
> > > index 0000000..f32d228
> > > --- /dev/null
> > > +++ b/recipes-bsp/ipumm-fw/ipumm-fw_3.00.06.00.bb
> > > @@ -0,0 +1,36 @@
> > > +DESCRIPTION = "Firmware for IPU "
> > 
> > What kind of firmware for IPU this is? It doesn't need to be very detailed, but
> > spelling out some generic "purpose" of the firmware would be nice.
> > 
> > 
> > > +LICENSE = "TI-TSPA"
> > > +
> > > +
> > > +LIC_FILES_CHKSUM_dra7xx-evm = "file://MMIP-${PV}-
> > Manifest.doc;md5=8206ccaf28c2932afb5afd9c9575287c"
> > > +LIC_FILES_CHKSUM_omap5-evm = "file://MMIP-${PV}-
> > Manifest.doc;md5=39a593dd8fc2a9654c74f679ed329c45"
> > > +
> > > +COMPATIBLE_MACHINE = "omap-a15"
> > > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > +
> > > +SRC_URI = ""
> > > +SRC_URI_append_dra7xx-evm =
> > "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/ipumm/3_00_06_00/e
> > xports/ipumm-${MACHINE}-
> > 3.00.06.00.tar.gz;protocol=ftp;name=${MACHINE}"
> > > +
> > > +SRC_URI_append_omap5-evm  =
> > "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/ipumm/3_00_04_02/e
> > xports/ipumm-${MACHINE}-
> > 3.00.04.02.tar.gz;protocol=http;name=${MACHINE}"
> > 
> > Why not set SRC_URI_dra7xx-evm and SRC_URI_omap5-evm directly?
> > 
> > 
> > > +# DRA7xx checksums
> > > +SRC_URI[dra7xx-evm.md5sum] =
> > "8e1ae40eb10d631318d001463fa11d79"
> > > +SRC_URI[dra7xx-evm.sha256sum] =
> > "30c275146c34d11dbc2dfd568f0bbc3098a13cd981eee8a7a9766cb07d2f1ca
> > 5"
> > > +
> > > +# OMAP5 checksums
> > > +SRC_URI[omap5-evm.md5sum] =
> > "1572073ebd4f6d127c4e8cf47d270b6a"
> > > +SRC_URI[omap5-evm.sha256sum] =
> > "2fdb469f19e3c9984854f5bc82444fca4d7da869f5e645da22ec0d5beaa5cc65
> > "
> > > +
> > > +S = "${WORKDIR}/ipumm-${MACHINE}-${PV}"
> > > +
> > > +TARGET_dra7xx-evm = "dra7-ipu2-fw.xem4"
> > > +TARGET_omap5-evm = "ducati-m3-core0.xem3"
> > > +
> > > +do_install() {
> > > +        mkdir -p ${D}${base_libdir}/firmware
> > > +        cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> > > +}
> > > +
> > > +FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> > > +
> > > +PR = "r2"
> > > --
> > > 1.7.9.5
> > >
> > > --
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti