Re: [PATCH] PCI/MSI: Remove the redundant irq_set_msi_desc()

[Bjorn Helgaas <bhelgaas@google.com>]

On Wed, Sep 10, 2014 at 11:47:32AM +0800, Yijing Wang wrote:
> Irq and msi_desc will be associated in arch MSI
> setup code. The irq_set_msi_desc() in msix_program_entries()
> is redundant.

Can you help me review this by mentioning exactly *where* the IRQ and
msi_desc are associated by the arch MSI setup code?

> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
>  drivers/pci/msi.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 5a40516..902b0cb 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -719,7 +719,6 @@ static void msix_program_entries(struct pci_dev *dev,
>  						PCI_MSIX_ENTRY_VECTOR_CTRL;
>  
>  		entries[i].vector = entry->irq;
> -		irq_set_msi_desc(entry->irq, entry);
>  		entry->masked = readl(entry->mask_base + offset);
>  		msix_mask_irq(entry, 1);
>  		i++;
> -- 
> 1.7.1
>