From: Colin Watson <cjwatson@ubuntu.com>
To: grub-devel@gnu.org
Subject: Re: DNS endianness
Date: Tue, 23 Sep 2014 20:07:40 +0100 [thread overview]
Message-ID: <20140923190740.GA7552@riva.ucam.org> (raw)
In-Reply-To: <20140922205325.132df618@opensuse.site>
On Mon, Sep 22, 2014 at 08:53:25PM +0400, Andrei Borzenkov wrote:
> This does not sound right ...
>
> static grub_err_t
> recv_hook (grub_net_udp_socket_t sock __attribute__ ((unused)),
> struct grub_net_buff *nb,
> void *data_)
> {
> ...
> head = (struct dns_header *) nb->data;
> ...
> for (i = 0; i < grub_cpu_to_be16 (head->qdcount); i++)
> {
>
> We sure want to convert *to* cpu, not *from* cpu here? Same in all
> other places in this function.
The operations are precisely synonymous in all cases, so you should just
use whichever spelling is clearest.
--
Colin Watson [cjwatson@ubuntu.com]
next prev parent reply other threads:[~2014-09-23 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 16:53 DNS endianness Andrei Borzenkov
2014-09-23 19:07 ` Colin Watson [this message]
2015-05-07 15:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923190740.GA7552@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.