From: David Gibson <david@gibson.dropbear.id.au>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PULL 2/2] vfio: make rom read endian sensitive
Date: Wed, 24 Sep 2014 10:56:01 +1000 [thread overview]
Message-ID: <20140924005601.GE24332@voom.redhat.com> (raw)
In-Reply-To: <20140923171457.6258.99078.stgit@bling.home>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Tue, Sep 23, 2014 at 11:14:57AM -0600, Alex Williamson wrote:
> From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
>
> All memory regions used by VFIO are LITTLE_ENDIAN and they
> already take care of endiannes when accessing real device BARs
> except ROM - it was broken on BE hosts.
>
> This fixes endiannes for ROM BARs the same way as it is done
> for other BARs.
>
> This has been tested on PPC64 BE/LE host/guest in all possible
> combinations including TCG.
>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> [aik: added commit log]
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-24 1:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 17:14 [Qemu-devel] [PULL 0/2] VFIO endian updates Alex Williamson
2014-09-23 17:14 ` [Qemu-devel] [PULL 1/2] Revert "vfio: Make BARs native endian" Alex Williamson
2014-09-24 0:55 ` David Gibson
2014-09-23 17:14 ` [Qemu-devel] [PULL 2/2] vfio: make rom read endian sensitive Alex Williamson
2014-09-24 0:56 ` David Gibson [this message]
2014-09-24 11:50 ` [Qemu-devel] [PULL 0/2] VFIO endian updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924005601.GE24332@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.