From: Vinod Koul <vinod.koul@intel.com>
To: Roman Gushchin <klamm@yandex-team.ru>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages
Date: Wed, 24 Sep 2014 10:27:01 +0530 [thread overview]
Message-ID: <20140924045701.GR24663@intel.com> (raw)
In-Reply-To: <87d2bdcask.wl%klamm@yandex-team.ru>
On Wed, Sep 03, 2014 at 01:28:59PM +0400, Roman Gushchin wrote:
> dma_pin_iovec_pages() calls get_user_pages() for each iovec. If
> get_user_pages() returns a number smaller than the requested number,
> dma_pin_iovec_pages() calls dma_unpin_iovec_pages(). It releases
> previously allocated iovecs, but pages pinned by last get_user_pages()
> call remain unreleased.
> Fix this by calling put_page() for each such page.
>
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2014-09-24 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:28 [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages Roman Gushchin
2014-09-19 12:04 ` Roman Gushchin
2014-09-24 4:57 ` Vinod Koul [this message]
2014-09-24 6:27 ` Dan Williams
2014-09-25 16:16 ` Vinod Koul
2014-09-28 15:36 ` Dan Williams
2014-09-28 15:25 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924045701.GR24663@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=klamm@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.