From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XWf39-0004Ao-K9
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:23:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XWf30-00032K-Iv
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:23:35 -0400
Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]:34186)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XWf30-0002zu-BH
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:23:26 -0400
Received: by mail-pa0-f42.google.com with SMTP id et14so7927152pad.15
	for <qemu-devel@nongnu.org>; Tue, 23 Sep 2014 22:23:20 -0700 (PDT)
Date: Wed, 24 Sep 2014 13:23:16 +0800
From: Jun Li <junmuzi@gmail.com>
Message-ID: <20140924052315.GA8021@localhost.localdomain>
References: <1411477988-10678-1-git-send-email-junmuzi@gmail.com>
	<5421A412.2080505@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5421A412.2080505@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Modify qemu_opt_rename to realize renaming
 all items in opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, juli@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, 09/23 10:47, Eric Blake wrote:
> On 09/23/2014 07:13 AM, Jun Li wrote:
> > Add realization of rename all items in opts for qemu_opt_rename.
> > e.g:
> > When add bps twice in command line, need to rename all bps to
> > throttling.bps-total.
> > 
> > Signed-off-by: Jun Li <junmuzi@gmail.com>
> > ---
> > This patch solved following bug:
> > Bug 1145586 - qemu-kvm will give strange hint when add bps twice for a drive
> > ref:https://bugzilla.redhat.com/show_bug.cgi?id=1145586
> 
> Including that bug link in the commit message might be nice for someone
> visiting this patch a year from now.

ok, got it.

> 
> > ---
> >  blockdev.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/blockdev.c b/blockdev.c
> > index b361fbb..7c39a06 100644
> > --- a/blockdev.c
> > +++ b/blockdev.c
> > @@ -536,10 +536,15 @@ static void qemu_opt_rename(QemuOpts *opts, const char *from, const char *to)
> >  {
> >      const char *value;
> >  
> > -    value = qemu_opt_get(opts, from);
> > -    if (value) {
> > -        qemu_opt_set(opts, to, value);
> > -        qemu_opt_unset(opts, from);
> > +    /* rename all items */
> > +    while (1) {
> > +        value = qemu_opt_get(opts, from);
> 
> Can't this just be written as:
> 
> while ((value = qemu_opt_get(opts, from))) {
> 
> > +        if (value) {
> > +            qemu_opt_set(opts, to, value);
> > +            qemu_opt_unset(opts, from);
> > +        } else {
> > +            break;
> > +        }
> 
> and lose the if/else and break?  But that's style, not functional, so:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks. I will submit a new version.

Best Regards,
Jun Li