From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: reduce memory footprint for debugging Date: Wed, 24 Sep 2014 10:30:28 +0200 Message-ID: <20140924083028.GK15734@phenom.ffwll.local> References: <1452772.eQ4uGTB4Tx@pebbles.site> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id C09A36E0FE for ; Wed, 24 Sep 2014 01:30:32 -0700 (PDT) Received: by mail-wi0-f172.google.com with SMTP id em10so6398027wid.5 for ; Wed, 24 Sep 2014 01:30:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1452772.eQ4uGTB4Tx@pebbles.site> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Sep 23, 2014 at 08:04:07PM +0200, Stefan Br=FCns wrote: > see df8fbc231b7e4a78dae2b02e116fe73e4ea63cb0 > = > Signed-off-by: Stefan Br=FCns I already have such a patch: commit a8e98153627dfbb10ff4dd65729676115a932b2e Author: Andy Shevchenko Date: Mon Sep 1 14:12:01 2014 +0300 drm: i915: reduce memory footprint when debugging Please check linux-next before doing such cleanup patches next time around. Thanks, Daniel > --- > drivers/gpu/drm/i915/intel_dp.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel= _dp.c > index fdff1d4..dafb169 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -3322,15 +3322,12 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp) > struct drm_device *dev =3D dig_port->base.base.dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > = > - char dpcd_hex_dump[sizeof(intel_dp->dpcd) * 3]; > - > if (intel_dp_dpcd_read_wake(&intel_dp->aux, 0x000, intel_dp->dpcd, > sizeof(intel_dp->dpcd)) < 0) > return false; /* aux transfer failed */ > = > - hex_dump_to_buffer(intel_dp->dpcd, sizeof(intel_dp->dpcd), > - 32, 1, dpcd_hex_dump, sizeof(dpcd_hex_dump), false); > - DRM_DEBUG_KMS("DPCD: %s\n", dpcd_hex_dump); > + DRM_DEBUG_KMS("DPCD: %*ph\n", (int)sizeof(intel_dp->dpcd), > + dig_connector->dpcd); > = > if (intel_dp->dpcd[DP_DPCD_REV] =3D=3D 0) > return false; /* DPCD not present */ > -- = > 1.8.4.5 > = > = > -- = > Stefan Br=FCns / Bergstra=DFe 21 / 52062 Aachen > home: +49 241 53809034 mobile: +49 151 50412019 > work: +49 2405 49936-424 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch