From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup_board()
Date: Wed, 24 Sep 2014 12:45:30 +0300 [thread overview]
Message-ID: <20140924094530.GC5811@mwanda> (raw)
In-Reply-To: <20140923002236.GA20782@devel>
On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
> static void dgap_release_remap(struct board_t *brd)
> {
> - release_mem_region(brd->membase, 0x200000);
> - release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000);
> - iounmap(brd->re_map_membase);
> - iounmap(brd->re_map_port);
> + if (brd->re_map_membase) {
I hate this if conditions. Let's not complicate dgap_release_remap(),
let's fix the callers instead. Especially dgap_init_module() is a
totally sucky function with bad unwinding.
Let's not apply this patch.
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-24 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 0:22 [PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup_board() Daeseok Youn
2014-09-24 9:45 ` Dan Carpenter [this message]
2014-09-25 0:26 ` DaeSeok Youn
2014-09-25 7:50 ` Dan Carpenter
2014-09-25 8:39 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924094530.GC5811@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.