From: Alexander Aring <alex.aring@gmail.com>
To: Simon Vincent <simon.vincent@xsilon.com>
Cc: linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com,
marcel@holtmann.org
Subject: Re: [PATCH linux-wpan v4] ieee802154: 6lowpan: ensure header compression does not corrupt ipv6 header
Date: Wed, 24 Sep 2014 11:50:50 +0200 [thread overview]
Message-ID: <20140924095049.GA5246@omega> (raw)
In-Reply-To: <1411401123-7790-1-git-send-email-simon.vincent@xsilon.com>
Hi Simon,
On Mon, Sep 22, 2014 at 04:52:03PM +0100, Simon Vincent wrote:
> The 6lowpan ipv6 header compression was causing problems for other interfaces
> that expected a ipv6 header to still be in place, as we were replacing the
> ipv6 header with a compressed version. This happened if you sent a packet to a
> multicast address as the packet would be output on 802.15.4, ethernet, and also
> be sent to the loopback interface. The skb data was shared between these
> interfaces so all interfaces ended up with a compressed ipv6 header.
> The solution is to ensure that before we do any header compression we are not
> sharing the skb or skb data with any other interface. If we are then we must
> take a copy of the skb and skb data before modifying the ipv6 header.
> The only place we can copy the skb is inside the xmit function so we don't
> leave dangling references to skb.
> This patch moves all the header compression to inside the xmit function. Very
> little code has been changed it has mostly been moved from lowpan_header_create
> to lowpan_xmit. At the top of the xmit function we now check if the skb is
> shared and if so copy it. In lowpan_header_create all we do now is store the
> source and destination addresses for use later when we compress the header.
>
> Signed-off-by: Simon Vincent <simon.vincent@xsilon.com>
patch has been applied to linux-wpan-next/testing.
Minor changes "__le16 mode" to "u8 mode".
Thanks for your effort to pointing this issue out.
- Alex
prev parent reply other threads:[~2014-09-24 9:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:52 [PATCH linux-wpan v4] ieee802154: 6lowpan: ensure header compression does not corrupt ipv6 header Simon Vincent
2014-09-22 16:21 ` Alexander Aring
2014-09-22 17:02 ` Alexander Aring
2014-09-23 9:13 ` Jukka Rissanen
2014-09-23 9:26 ` Alexander Aring
2014-09-23 9:35 ` Alexander Aring
2014-09-23 10:14 ` Jukka Rissanen
2014-09-23 10:33 ` Alexander Aring
2014-09-23 10:45 ` Jukka Rissanen
2014-09-23 15:23 ` Marcel Holtmann
2014-09-23 15:36 ` Alexander Aring
2014-09-23 16:19 ` Marcel Holtmann
2014-09-24 9:47 ` Alexander Aring
2014-09-24 9:55 ` Marcel Holtmann
2014-09-24 10:04 ` Alexander Aring
2014-09-24 12:24 ` Marcel Holtmann
2014-09-24 12:49 ` Alexander Aring
2014-09-23 14:20 ` Jukka Rissanen
2014-09-23 14:43 ` Alexander Aring
2014-09-23 15:03 ` Alexander Aring
2014-09-24 7:10 ` Jukka Rissanen
2014-09-24 7:11 ` Alexander Aring
2014-09-23 10:16 ` Jukka Rissanen
2014-09-22 17:20 ` Alexander Aring
2014-09-24 9:50 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924095049.GA5246@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=simon.vincent@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.