From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Christoph Hellwig <hch@lst.de>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/4] nfsd: split nfsd4_callback initialization and use
Date: Wed, 24 Sep 2014 18:43:41 +0200 [thread overview]
Message-ID: <20140924164341.GA10208@lst.de> (raw)
In-Reply-To: <20140924112954.5d0771b8@tlielax.poochiereds.net>
On Wed, Sep 24, 2014 at 11:29:54AM -0400, Jeff Layton wrote:
> > Split out initializing the nfs4_callback structure from using it. For
> > the NULL callback this gets rid of tons of pointless re-initializations.
> >
> > Note that I don't quite understand what protects us from running multiple
> > NULL callbacks at the same time, but at least this chance doesn't make
> > it worse..
> >
>
> Doesn't the workqueue ensure that? Or am I misunderstanding what you're
> saying there?
For the code after my patch that is indeed the case, but before my
patch we'd re-initialize various fields in cl_cb_null everytime
do_probe_callback gets called.
next prev parent reply other threads:[~2014-09-24 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 10:19 refactor nfsd callback handling Christoph Hellwig
2014-09-24 10:19 ` [PATCH 1/4] nfsd: remove nfsd4_callback.cb_op Christoph Hellwig
2014-09-24 10:19 ` [PATCH 2/4] nfsd: introduce a generic nfsd4_cb Christoph Hellwig
2014-09-24 10:19 ` [PATCH 3/4] nfsd: split nfsd4_callback initialization and use Christoph Hellwig
2014-09-24 15:29 ` Jeff Layton
2014-09-24 16:43 ` Christoph Hellwig [this message]
2014-09-24 10:19 ` [PATCH 4/4] nfsd: introduce nfsd4_callback_ops Christoph Hellwig
2014-09-24 15:30 ` refactor nfsd callback handling Jeff Layton
2014-09-26 18:03 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924164341.GA10208@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.