From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
kbuild-all@01.org
Subject: Re: [next:master 7267/7446] drivers/rtc/rtc-bq32k.c:169:3: warning: 'setup' may be used uninitialized in this function
Date: Wed, 24 Sep 2014 18:49:25 +0200 [thread overview]
Message-ID: <20140924164925.GA1231@amd> (raw)
In-Reply-To: <20140923140109.d1e81b714082e562b7fb3e2c@linux-foundation.org>
On Tue 2014-09-23 14:01:09, Andrew Morton wrote:
> On Tue, 23 Sep 2014 16:40:24 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 55f21306900abf9f9d2a087a127ff49c6d388ad2
> > commit: 7bb72683b1708c3cf3bea0575c0e80314a2232dc [7267/7446] rtc: bq32000: add trickle charger option, with device tree binding
> > config: i386-randconfig-ib0-09231629 (attached as .config)
> > reproduce:
> > git checkout 7bb72683b1708c3cf3bea0575c0e80314a2232dc
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
> > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
> >
> > All warnings:
> >
> > drivers/rtc/rtc-bq32k.c: In function 'trickle_charger_of_init':
> > drivers/rtc/rtc-bq32k.c:155:7: warning: assignment makes pointer from integer without a cast
> > reg = 0x05;
> > ^
> > drivers/rtc/rtc-bq32k.c:165:7: warning: assignment makes pointer from integer without a cast
> > reg = 0x25;
> > ^
> > drivers/rtc/rtc-bq32k.c:177:6: warning: assignment makes pointer from integer without a cast
> > reg = 0x20;
> > ^
> > drivers/rtc/rtc-bq32k.c:135:6: warning: unused variable 'plen' [-Wunused-variable]
> > int plen = 0;
> > ^
> > drivers/rtc/rtc-bq32k.c: In function 'bq32k_probe':
> > >> drivers/rtc/rtc-bq32k.c:169:3: warning: 'setup' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > dev_err(dev, "invalid resistor value (%d)\n", *setup);
> > ^
> > drivers/rtc/rtc-bq32k.c:136:18: note: 'setup' was declared here
> > const uint32_t *setup;
>
> Pavel's changelog failed to tell us what warnings were being fixed
> (bad!) but I expect the below will fix this.
Yes, it should. Thanks for patience,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-09-24 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 8:40 [next:master 7267/7446] drivers/rtc/rtc-bq32k.c:169:3: warning: 'setup' may be used uninitialized in this function kbuild test robot
2014-09-23 19:40 ` [patch] drivers/rtc/rtc-bq32k.c fix warnings I introduced Pavel Machek
2014-09-23 19:40 ` Pavel Machek
2014-09-23 21:01 ` [next:master 7267/7446] drivers/rtc/rtc-bq32k.c:169:3: warning: 'setup' may be used uninitialized in this function Andrew Morton
2014-09-24 16:49 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924164925.GA1231@amd \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.