From: Thierry Reding <thierry.reding@gmail.com>
To: Nikolaus Voss <n.voss@weinmann-emt.de>
Cc: Bo Shen <voice.shen@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: atmel-pwm: fix calculation of prescale value
Date: Thu, 25 Sep 2014 09:49:48 +0200 [thread overview]
Message-ID: <20140925074947.GA11843@ulmo> (raw)
In-Reply-To: <alpine.DEB.2.10.1409250934090.38376@fox.voss.local>
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Thu, Sep 25, 2014 at 09:47:34AM +0200, Nikolaus Voss wrote:
> On Thu, 25 Sep 2014, Thierry Reding wrote:
[...]
> >>- }
> >>+ div >>= 1;
> >>+ ++pres;
> >
> >Unless you really need the prefix increment behaviour (you don't in this
> >case) I prefer using the postfix operator because it is slightly more
> >idiomatic.
>
> ok (as I mostly do C++ programming, I prefer the prefix as it is usually
> more efficient for user-defined types).
It is? That's intriguing...
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-25 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140924055851.CE51140656@mail.steuer-voss.de>
2014-09-25 6:52 ` [PATCH] pwm: atmel-pwm: fix calculation of prescale value Thierry Reding
2014-09-25 7:47 ` Nikolaus Voss
2014-09-25 7:49 ` Thierry Reding [this message]
2014-09-23 13:30 Nikolaus Voss
2014-09-25 1:50 ` Bo Shen
2014-09-25 1:53 ` Bo Shen
2014-09-25 1:53 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925074947.GA11843@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n.voss@weinmann-emt.de \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.